kenhuuu commented on code in PR #1833:
URL: https://github.com/apache/tinkerpop/pull/1833#discussion_r1006132090
##########
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Cluster.java:
##########
@@ -205,6 +205,7 @@ private static Builder getBuilderFromSettings(final
Settings settings) {
.maxConnectionPoolSize(settings.connectionPool.maxSize)
.minConnectionPoolSize(settings.connectionPool.minSize)
.connectionSetupTimeoutMillis(settings.connectionPool.connectionSetupTimeoutMillis)
+
.sslHandshakeTimeoutMillis(settings.connectionPool.sslHandshakeTimeoutMillis)
Review Comment:
It was also brought to my attention that a potential issue with setting the
default to 0 is that it might mask the underlying cause of the timeout issue.
The user would see that there was a connection setup timeout but they wouldn't
know that it was caused by a timeout in the SSL handshake. Netty won't throw a
SSL handshake related exception if the value is set to 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
