kenhuuu commented on code in PR #1833:
URL: https://github.com/apache/tinkerpop/pull/1833#discussion_r1006126758
##########
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Cluster.java:
##########
@@ -205,6 +205,7 @@ private static Builder getBuilderFromSettings(final
Settings settings) {
.maxConnectionPoolSize(settings.connectionPool.maxSize)
.minConnectionPoolSize(settings.connectionPool.minSize)
.connectionSetupTimeoutMillis(settings.connectionPool.connectionSetupTimeoutMillis)
+
.sslHandshakeTimeoutMillis(settings.connectionPool.sslHandshakeTimeoutMillis)
Review Comment:
Hi Divij, could you clarify some recent comments? Did you mean to say that
we shouldn't add another configuration for the SSL timeout and instead we
should just internally set this to a percentage of
connectionSetupTimeoutMillis? Or, did you mean that we should add a
configuration but it should be percentage based and the default could be 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
