kenhuuu commented on code in PR #1833:
URL: https://github.com/apache/tinkerpop/pull/1833#discussion_r1006134782
##########
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Cluster.java:
##########
@@ -986,13 +996,26 @@ public Builder port(final int port) {
* handshake and SSL handshake. Beyond this duration an exception
would be thrown.
*
* Note that this value should be greater that SSL handshake timeout
defined in
- * {@link io.netty.handler.ssl.SslHandler} since WebSocket handshake
include SSL handshake.
+ * {@link io.netty.handler.ssl.SslHandler} since WebSocket handshake
include SSL handshake. This value should be
+ * less than {@link Builder#maxWaitForConnection}.
Review Comment:
Could you clarify this? Did you mean adding a param line? If so, I didn't do
this as it seemed a bit redundant and it isn't done for any of the other params
in this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
