spmallette commented on code in PR #1833:
URL: https://github.com/apache/tinkerpop/pull/1833#discussion_r1002770311
##########
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Cluster.java:
##########
@@ -205,6 +205,7 @@ private static Builder getBuilderFromSettings(final
Settings settings) {
.maxConnectionPoolSize(settings.connectionPool.maxSize)
.minConnectionPoolSize(settings.connectionPool.minSize)
.connectionSetupTimeoutMillis(settings.connectionPool.connectionSetupTimeoutMillis)
+
.sslHandshakeTimeoutMillis(settings.connectionPool.sslHandshakeTimeoutMillis)
Review Comment:
i'm pretty sure that we dont have any other timeouts interrelated to
`connectionSetupTimeoutMillis` (but please double check my recollection) so I
think I'm ok with using a percentage here. if we do it as a percentage, then
i'd be ok with 0 as the default. that seems to make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
