[
https://issues.apache.org/jira/browse/TOMEE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719055#comment-16719055
]
ASF GitHub Bot commented on TOMEE-2337:
---------------------------------------
Github user pzygielo commented on a diff in the pull request:
https://github.com/apache/tomee/pull/262#discussion_r241048270
--- Diff:
container/openejb-loader/src/main/java/org/apache/openejb/observer/event/ObserverRemoved.java
---
@@ -26,10 +26,20 @@
private final Object observer;
+ /**
+ * Remove the observable object so this object doesn't have any
observers
--- End diff --
I don't think that's true. It is constructor, and it apparently does not
remove anything.
> Code cleanup: module openejb-loader
> -----------------------------------
>
> Key: TOMEE-2337
> URL: https://issues.apache.org/jira/browse/TOMEE-2337
> Project: TomEE
> Issue Type: Improvement
> Affects Versions: 8.0.0-M1, 7.1.0
> Reporter: Hayri Cicek
> Priority: Trivial
> Labels: pull-request-available
>
> Use diamond operator, JavaDoc and if possible final variables/parameters
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
