[ 
https://issues.apache.org/jira/browse/TOMEE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719065#comment-16719065
 ] 

ASF GitHub Bot commented on TOMEE-2337:
---------------------------------------

Github user pzygielo commented on a diff in the pull request:

    https://github.com/apache/tomee/pull/262#discussion_r241049965
  
    --- Diff: 
container/openejb-loader/src/main/java/org/apache/openejb/observer/event/ObserverAdded.java
 ---
    @@ -26,10 +26,20 @@
     
         private final Object observer;
     
    +    /**
    +     * Add the provided object to be observable
    +     * 
    +     * @param observer
    +     */
         public ObserverAdded(final Object observer) {
             this.observer = observer;
         }
     
    +    /**
    +     * Return the observable object
    --- End diff --
    
    Do you consider observable the same as observer?


> Code cleanup: module openejb-loader
> -----------------------------------
>
>                 Key: TOMEE-2337
>                 URL: https://issues.apache.org/jira/browse/TOMEE-2337
>             Project: TomEE
>          Issue Type: Improvement
>    Affects Versions: 8.0.0-M1, 7.1.0
>            Reporter: Hayri Cicek
>            Priority: Trivial
>              Labels: pull-request-available
>
> Use diamond operator, JavaDoc and if possible final variables/parameters



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to