[
https://issues.apache.org/jira/browse/TOMEE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719109#comment-16719109
]
ASF GitHub Bot commented on TOMEE-2337:
---------------------------------------
Github user pzygielo commented on a diff in the pull request:
https://github.com/apache/tomee/pull/262#discussion_r241067971
--- Diff:
container/openejb-loader/src/main/java/org/apache/openejb/loader/FileUtils.java
---
@@ -120,10 +150,19 @@ public File getFile(final String path, final boolean
validate) throws IOExceptio
return file;
}
+ /**
+ * Creates Temp Directory
+ *
+ * Throws IOException if directory doesn't exists and if it fails to
create directories
--- End diff --
- It belongs to `@throws` tag, I think.
- > if directory doesn't exists
1. exist~~s~~
1. Which one? The one we want to create? We have no control over random
used in the method, so how can programmer react to that IOEx?
- > doesn't exists and if it fails
What happens if all 100 *candidate directories* exist already? I see the
method will throw as well. So your description is not quite correct.
> Code cleanup: module openejb-loader
> -----------------------------------
>
> Key: TOMEE-2337
> URL: https://issues.apache.org/jira/browse/TOMEE-2337
> Project: TomEE
> Issue Type: Improvement
> Affects Versions: 8.0.0-M1, 7.1.0
> Reporter: Hayri Cicek
> Priority: Trivial
> Labels: pull-request-available
>
> Use diamond operator, JavaDoc and if possible final variables/parameters
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
