[
https://issues.apache.org/jira/browse/TOMEE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719067#comment-16719067
]
ASF GitHub Bot commented on TOMEE-2337:
---------------------------------------
Github user pzygielo commented on a diff in the pull request:
https://github.com/apache/tomee/pull/262#discussion_r241051038
--- Diff:
container/openejb-loader/src/main/java/org/apache/openejb/observer/ObserverManager.java
---
@@ -74,6 +80,12 @@ public boolean addObserver(final Object observer) {
}
}
+ /**
+ * Remove the observable object so this object doesn't have any
observers
--- End diff --
I think only specified `observer` will be removed, and all the rest will be
kept.
And observable will not be removed.
> Code cleanup: module openejb-loader
> -----------------------------------
>
> Key: TOMEE-2337
> URL: https://issues.apache.org/jira/browse/TOMEE-2337
> Project: TomEE
> Issue Type: Improvement
> Affects Versions: 8.0.0-M1, 7.1.0
> Reporter: Hayri Cicek
> Priority: Trivial
> Labels: pull-request-available
>
> Use diamond operator, JavaDoc and if possible final variables/parameters
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
