[
https://issues.apache.org/jira/browse/TOMEE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720573#comment-16720573
]
ASF GitHub Bot commented on TOMEE-2337:
---------------------------------------
Github user otaviojava commented on a diff in the pull request:
https://github.com/apache/tomee/pull/262#discussion_r241549359
--- Diff:
container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java
---
@@ -111,6 +132,12 @@ public boolean accept(final File dir, String name) {
}
}
+ /**
+ *
--- End diff --
I'm fine to keep the javadoc, once it has comments otherwise, i think is
better remove it
> Code cleanup: module openejb-loader
> -----------------------------------
>
> Key: TOMEE-2337
> URL: https://issues.apache.org/jira/browse/TOMEE-2337
> Project: TomEE
> Issue Type: Improvement
> Affects Versions: 7.1.0, 8.0.0-M1
> Reporter: Hayri Cicek
> Priority: Trivial
> Labels: pull-request-available
>
> Use diamond operator, JavaDoc and if possible final variables/parameters
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
