tqchen commented on a change in pull request #8768:
URL: https://github.com/apache/tvm/pull/8768#discussion_r691325082



##########
File path: include/tvm/ir/type.h
##########
@@ -164,10 +164,17 @@ class PointerTypeNode : public TypeNode {
   }
 
   bool SEqualReduce(const PointerTypeNode* other, SEqualReducer equal) const {
-    return equal(element_type, other->element_type);
+    // Make "global" equal to ""
+    String lhs_scope = storage_scope.empty() ? "global" : storage_scope;

Review comment:
       I agree that should be the cause of action in the long run. There can be 
some TE legacy setups that we need to fix before making this change. So one 
thing we can do is to first bring this in, then do an additional refactor later.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to