Hzfengsy commented on a change in pull request #8768:
URL: https://github.com/apache/tvm/pull/8768#discussion_r691814440



##########
File path: include/tvm/ir/type.h
##########
@@ -164,10 +164,17 @@ class PointerTypeNode : public TypeNode {
   }
 
   bool SEqualReduce(const PointerTypeNode* other, SEqualReducer equal) const {
-    return equal(element_type, other->element_type);
+    // Make "global" equal to ""
+    String lhs_scope = storage_scope.empty() ? "global" : storage_scope;

Review comment:
       Thanks @Mousius. Changing the default storage_scope to "global" is 
exactly what we want in the long run. But there are some TE mechanism based on 
an empty scope.
   
   I have checked the codes and found that this function will use Stage scope 
to create `RealizeNode` and further to create a buffer with the stage scope. 
https://github.com/apache/tvm/blob/41879b2552364f094492470a77a3ec0866b30eae/src/te/schedule/schedule_ops.cc#L43-L56




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to