Mousius commented on a change in pull request #8768:
URL: https://github.com/apache/tvm/pull/8768#discussion_r691247449
##########
File path: include/tvm/ir/type.h
##########
@@ -164,10 +164,17 @@ class PointerTypeNode : public TypeNode {
}
bool SEqualReduce(const PointerTypeNode* other, SEqualReducer equal) const {
- return equal(element_type, other->element_type);
+ // Make "global" equal to ""
+ String lhs_scope = storage_scope.empty() ? "global" : storage_scope;
Review comment:
Rather than implicitly making `"" == "global"` could we instead change
the default `storage_scope` to `"global"` ? WDYT @junrushao1994 ?
##########
File path: include/tvm/ir/type.h
##########
@@ -164,10 +164,17 @@ class PointerTypeNode : public TypeNode {
}
bool SEqualReduce(const PointerTypeNode* other, SEqualReducer equal) const {
- return equal(element_type, other->element_type);
+ // Make "global" equal to ""
+ String lhs_scope = storage_scope.empty() ? "global" : storage_scope;
Review comment:
I tried the initial commit here with a find/replace of `storage_scope =
""` -> `storage_scope = "global"` and `storage_scope=""` ->
`storage_scope="global"` as well as changing `scope` in `decl_buffer` in
`python/tvm/tir/buffer.py`. These changes pass tests in
`./tests/scripts/task_python_unittest.sh` and
`./tests/scripts/task_python_integration.sh`, are there other parts of TE to
update @tqchen ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
