Hzfengsy commented on a change in pull request #8768:
URL: https://github.com/apache/tvm/pull/8768#discussion_r691965112
##########
File path: include/tvm/ir/type.h
##########
@@ -164,10 +164,17 @@ class PointerTypeNode : public TypeNode {
}
bool SEqualReduce(const PointerTypeNode* other, SEqualReducer equal) const {
- return equal(element_type, other->element_type);
+ // Make "global" equal to ""
+ String lhs_scope = storage_scope.empty() ? "global" : storage_scope;
Review comment:
Sorry for not explaining clearly. To be specific, I choose one test case
`tests/python/unittest/test_runtime_module_based_interface.py` for detail
explanation:
1. I repeat your changes that you mentioned before. The testcase passes.
2. However, when I add `ICHECK(!s->scope.empty())` at
`tvm/src/te/schedule/schedule_ops.cc` line 54. It fails.
3. Then, I enforce it to be "global" by changing lines, it also fails:
```cpp
String storage_scope = s->scope.empty() ? "global" : s->scope;
return s->op->BuildRealize(s, dom_map, pipeline, storage_scope);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
