Hzfengsy commented on a change in pull request #8768:
URL: https://github.com/apache/tvm/pull/8768#discussion_r692108660
##########
File path: include/tvm/ir/type.h
##########
@@ -164,10 +164,17 @@ class PointerTypeNode : public TypeNode {
}
bool SEqualReduce(const PointerTypeNode* other, SEqualReducer equal) const {
- return equal(element_type, other->element_type);
+ // Make "global" equal to ""
+ String lhs_scope = storage_scope.empty() ? "global" : storage_scope;
Review comment:
I totally agree to raise an issue for updating everything to "global".
We can do this refactoring at anytime if we have time. For now, I'd like to
commit this workaround, since there is another place to make `""` equals to
`"global"`:
https://github.com/apache/tvm/blob/41879b2552364f094492470a77a3ec0866b30eae/src/runtime/thread_storage_scope.h#L121-L127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
