Hzfengsy commented on a change in pull request #8768:
URL: https://github.com/apache/tvm/pull/8768#discussion_r692606120
##########
File path: include/tvm/ir/type.h
##########
@@ -164,10 +164,17 @@ class PointerTypeNode : public TypeNode {
}
bool SEqualReduce(const PointerTypeNode* other, SEqualReducer equal) const {
- return equal(element_type, other->element_type);
+ // Make "global" equal to ""
+ String lhs_scope = storage_scope.empty() ? "global" : storage_scope;
Review comment:
It's great if we use `"global"` in new codes. But we still need to make
`""` equals to `"global`" since there are some legacy codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
