tqchen commented on PR #14094: URL: https://github.com/apache/tvm/pull/14094#issuecomment-1441036000
Thank you for the contribution. As noted in the other thread and the RFC. Please resolve the goal of scoping different interface conventions. Specifically, given that there are multiple rust interfaces available in the TVM codebase, being able to do so would help to give space for general community. - G0: Avoid confusion with the normal rust API usage given there are multiple possibilities under a different API. One possible minimum approach would be renaming the file to interface_embedded_rust.cc, or move to a subfolder that signals such intent, feel free to rename interface_c.cc together if there is an urge to keep things consistent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
