Mousius commented on PR #14094: URL: https://github.com/apache/tvm/pull/14094#issuecomment-1441073135
> Agility is realized based on proper scoping of the changes. > > For example, the changes are reasonably scoped under a subfolder, sub-namespace, or branch that do not breaches into other things, then we would definitely love to enable such agility, knowing that changes won't create confusions in cases like multiple namespace. > > That is why I made such suggestions from the beginning, so such followup developments can be proceeded without breaching into other interfaces. Please refer back to my previous comment https://github.com/apache/tvm-rfcs/pull/96#issuecomment-1372661932, this is aligned with the existing architecture, demonstrating that this is reasonably scoped for the files that exist pending further changes to better remedy the situation. Please also refer back to that conversation as to why we shouldn't be introducing the inconsistency for one file. > Happy to review what comes along as well once you think they are ready. I'm indeed intending to raise additional pull requests to finish upstreaming this work, you are welcome to request changes on them all - as unwelcoming as this has become, I want to surface the user value even if it remains in a fork. As I've illustrated, this work is ready for review, trusting in myself as a committer to follow up and fix the area of the codebase I have already contributed much to. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
