Mousius commented on PR #14094: URL: https://github.com/apache/tvm/pull/14094#issuecomment-1441097869
> That part of merged code however, can also be revisited, and in the course of continuous conversation -- rather than being used as a simple golden rule. Remember it is only part of the code(that was not consistent with the rest of the architecture), and being consistent only with that one part of the code simply ignores the architecture as a whole. I'm simply demonstrating that the code already exists, and it would be architecturally consistent rather than introducing another inconsistency. I never said it was a golden rule, nor did I state it was in a good state, in fact I suggested we should do a larger piece of work to remedy it properly. > Please feel free to continue development in a way that is reasonably scoped, it can be a branch, a new namespace, sub folder or any other approach that would satisfied that goal, which was the course of action that most developers in the community would happily take. It's better to make any new interface as consistent with the old interface as possible, as I've highlighted in previous conversations, this is standard practice when interacting with existing code. I've also stated I would follow up to remedy the overall architecture, taking into account more than a single file, you've made it clear you do not trust me to do such a follow up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
