tqchen commented on PR #14094: URL: https://github.com/apache/tvm/pull/14094#issuecomment-1441085806
In this case I would come one step further and say existing architecture (if you were referring to target/interface_c) was also not properly scoped and would benefit from scoping. I did not review that particular change, nor did the scoping proposal included the RFC in the relevant changes. I (lazily) approved the RFC(including previous ones related to such embedded interface) based on the assumption that there would be proper scoping, as it were a common practices in the TVM project for most of the modules. Apparently there wasn't such a consideration, or a proposal when being asked. That merged code however, can also be revisited, and in the course of continuous conversation. Doing proper scoping would be necessarily for different contributors to operate in their subareas without having to step onto each other. While the perhaps the code implements the feature that was intended in the area that you contributed to, the current scoping of the module breaches other concurrent APIs. As a result that impacts grows to the overall architecture level of the project. From the standpt of overall project architecture, I would kindly request a proper scoping for the proposed module only. Please feel free to continue development in a way that is reasonably scoped, it can be a branch, a new namespace, sub folder or any other approach that would satisfied that goal, which was the course of action that most developers in the community would happily take. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
