Mousius commented on PR #14094: URL: https://github.com/apache/tvm/pull/14094#issuecomment-1441046328
> Thank you for the contribution. As noted in the other thread and the RFC. > > Please resolve the goal of scoping different interface conventions. Specifically, given that there are multiple rust interfaces available in the TVM codebase, being able to do so would help to give space for general community. > > * G0: Avoid confusion with the normal rust API usage given there are multiple possibilities under a different API. > > One possible minimum approach would be renaming the file to interface_embedded_rust.cc, or move to a subfolder that signals such intent, feel free to rename interface_c.cc together if there is an urge to keep things consistent Hi @tqchen, I clearly stated that this is pending the PR you are blocking, please re-visit https://github.com/apache/tvm/pull/13707#issuecomment-1428217041 as to why the goal you've outlined is inappropriate and why the renaming is the wrong action to take. As evidenced by this PR, there are more things to resolve around AOT interfaces APIs than simply renaming one file. I've also already stated I would be happy to do the follow up work to properly resolve this situation, you've articulated in many threads that you'd prefer a more agile culture yet it's clear that this isn't being applied in this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
