[ 
https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=795823&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795823
 ]

ASF GitHub Bot logged work on HADOOP-18357:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Jul/22 20:25
            Start Date: 27/Jul/22 20:25
    Worklog Time Spent: 10m 
      Work Description: goiri commented on code in PR #4616:
URL: https://github.com/apache/hadoop/pull/4616#discussion_r931549627


##########
hadoop-common-project/hadoop-common/src/main/native/native.vcxproj:
##########
@@ -39,12 +37,14 @@
     <UseDebugLibraries>false</UseDebugLibraries>
     <WholeProgramOptimization>true</WholeProgramOptimization>
     <CharacterSet>Unicode</CharacterSet>
+    <PlatformToolset>v142</PlatformToolset>

Review Comment:
   Take a look at HADOOP-14667
   Specially: `MSBuild Solution files are converted to the version of VS at 
build time`
   If this makes sense, we go with this.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 795823)
    Time Spent: 2.5h  (was: 2h 20m)

> Retarget solution file to VS2019
> --------------------------------
>
>                 Key: HADOOP-18357
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18357
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: common
>    Affects Versions: 3.4.0
>         Environment: Windows 10
>            Reporter: Gautham Banasandra
>            Assignee: Gautham Banasandra
>            Priority: Major
>              Labels: libhdfscpp, pull-request-available
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> The Visual Studio version used by winutils and native components in Hadoop 
> common are quite old. We need to retarget the solution and vcxproj files to 
> use the latest version (Visual Studio 2019 as of this writing).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to