[
https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=796048&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796048
]
ASF GitHub Bot logged work on HADOOP-18357:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jul/22 12:06
Start Date: 28/Jul/22 12:06
Worklog Time Spent: 10m
Work Description: GauthamBanasandra commented on code in PR #4616:
URL: https://github.com/apache/hadoop/pull/4616#discussion_r932136279
##########
hadoop-common-project/hadoop-common/src/main/native/native.vcxproj:
##########
@@ -39,12 +37,14 @@
<UseDebugLibraries>false</UseDebugLibraries>
<WholeProgramOptimization>true</WholeProgramOptimization>
<CharacterSet>Unicode</CharacterSet>
+ <PlatformToolset>v142</PlatformToolset>
Review Comment:
This is amazing. Thanks for sharing this @goiri 😊. I'm able to confirm that
while building the `hadoop-common-project` module, the vcxproj and solution
files automatically get upgraded to the appropriate Visual Studio version. All
thanks to
https://github.com/apache/hadoop/blob/95a85875d0038a73f7e6c2cdb6efdc5132d63beb/hadoop-common-project/hadoop-common/pom.xml#L844-L923
```
[INFO] -
Issue Time Tracking
-------------------
Worklog Id: (was: 796048)
Time Spent: 2h 40m (was: 2.5h)
> Retarget solution file to VS2019
> --------------------------------
>
> Key: HADOOP-18357
> URL: https://issues.apache.org/jira/browse/HADOOP-18357
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
> Affects Versions: 3.4.0
> Environment: Windows 10
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Major
> Labels: libhdfscpp, pull-request-available
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> The Visual Studio version used by winutils and native components in Hadoop
> common are quite old. We need to retarget the solution and vcxproj files to
> use the latest version (Visual Studio 2019 as of this writing).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
