K0K0V0K commented on code in PR #5784:
URL: https://github.com/apache/hadoop/pull/5784#discussion_r1267902588
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java:
##########
@@ -1088,8 +1088,15 @@ public void transition(RMAppImpl app, RMAppEvent event) {
// otherwise, add it to ranNodes for further process
app.ranNodes.add(nodeAddedEvent.getNodeId());
- app.logAggregation.addReportIfNecessary(
- nodeAddedEvent.getNodeId(), app.getApplicationId());
+ if (!nodeAddedEvent.isCreatedFromAcquiredState()) {
+ app.logAggregation.addReportIfNecessary(
+ nodeAddedEvent.getNodeId(), app.getApplicationId());
+ } else {
+ LOG.warn(String.format("Not considering container for log aggregation "
+ + "while app is transitioning from ACQUIRED directly to
RELEASED "
+ + "for nodeId: %s and appId: %s",
+ nodeAddedEvent.getNodeId(), app.getApplicationId()));
+ }
Review Comment:
I agree with both.
However i added the log message to the code cause i think this if solution
is a bit fishy, and if some one doing a debug here, maybe can cause troubles,
but the warning level is too high, i will change it to debug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
