saxenapranav commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1410207987
##########
hadoop-project/pom.xml:
##########
@@ -1288,10 +1288,22 @@
<artifactId>jackson-dataformat-cbor</artifactId>
<version>${jackson2.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-bom</artifactId>
+ <version>${mockito.version}</version>
+ <type>pom</type>
Review Comment:
This would import the dependency-management of mockito-bom. From,
https://central.sonatype.com/artifact/org.mockito/mockito-bom, looks like it
also has mockito-android. Was curious that if the dll files are coming because
of this. Also, do we need the bom, since we are adding dependencies for both
mockito-core and mockito-inline (because we would be importing many other
dependencies which might not be of use).
##########
hadoop-client-modules/hadoop-client-minicluster/pom.xml:
##########
@@ -400,6 +400,7 @@
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
+ <version>${mockito.version}</version>
Review Comment:
I think we can remove it. Since, hadoop-project is parent of this pom, and
in that, there is dependency-management which has this dependency with a
version. This would pick that version, if we remove version here.
##########
hadoop-client-modules/hadoop-client-check-test-invariants/src/test/resources/ensure-jars-have-correct-contents.sh:
##########
@@ -58,6 +58,10 @@
allowed_expr+="|^org.apache.hadoop.application-classloader.properties$"
allowed_expr+="|^java.policy$"
# * Used by javax.annotation
allowed_expr+="|^jndi.properties$"
+allowed_expr+="|^win32-x86/$"
Review Comment:
same for the other shell file.
##########
hadoop-client-modules/hadoop-client-check-test-invariants/src/test/resources/ensure-jars-have-correct-contents.sh:
##########
@@ -58,6 +58,10 @@
allowed_expr+="|^org.apache.hadoop.application-classloader.properties$"
allowed_expr+="|^java.policy$"
# * Used by javax.annotation
allowed_expr+="|^jndi.properties$"
+allowed_expr+="|^win32-x86/$"
Review Comment:
mockito-core is an optional dependency in minicluster -> it should not be
transitive and also would not be coming into classpath of this project (ref:
https://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html#how-do-optional-dependencies-work).
Was curious, what is the reason for these dll coming here.
Would be awesome, if you can add comment for the reasoning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
