saxenapranav commented on code in PR #6275: URL: https://github.com/apache/hadoop/pull/6275#discussion_r1420202409
########## hadoop-client-modules/hadoop-client-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh: ########## @@ -69,6 +69,10 @@ allowed_expr+="|^krb5_udp-template.conf$" allowed_expr+="|^jetty-dir.css$" # Snappy java is native library. We cannot relocate it to under org/apache/hadoop. allowed_expr+="|^org/xerial/" +allowed_expr+="|^win32-x86/$" +allowed_expr+="|^win32-x86/attach_hotspot_windows.dll$" Review Comment: Looks like its dlls will come in the minicluster jar. Reason being, mockito-core has a compile-dependency on byte-buddy-agent (so creating jar of minicluster bring in mockito-core, but also byte-buddy-agent by transitivity). The use of mockito-core as compile in minicluster looks like its there to help hadoop-hdfs test-jar run in integeration-test. Now, mockito-core may need these dlls in the flow defined by -> https://github.com/mockito/mockito/blob/d86bca62a4e9500567ffe97826865460a9c30f18/src/main/java/org/mockito/internal/creation/bytebuddy/InlineDelegateByteBuddyMockMaker.java#L133 -> which creates an object of VirtualMachine. These dlls would be used here: https://github.com/raphw/byte-buddy/blob/master/byte-buddy-agent/src/main/java/net/bytebuddy/agent/VirtualMachine.java#L1269. These dlls come on the root of the minicluster jar, and the VirtualMachine will be in org.apache.hadoop.shaded.net.bytebuddy.agent.VirtualMachine. The only concern is if the VirtualMachine triggering NativeLibrary API from shaded path can take up the dll on the root or if it has to be relocated to shaded path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
