steveloughran commented on code in PR #6275: URL: https://github.com/apache/hadoop/pull/6275#discussion_r1420351865
########## hadoop-client-modules/hadoop-client-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh: ########## @@ -69,6 +69,10 @@ allowed_expr+="|^krb5_udp-template.conf$" allowed_expr+="|^jetty-dir.css$" # Snappy java is native library. We cannot relocate it to under org/apache/hadoop. allowed_expr+="|^org/xerial/" +allowed_expr+="|^win32-x86/$" +allowed_expr+="|^win32-x86/attach_hotspot_windows.dll$" Review Comment: I have no idea what happens with DLLs and shaded libs. probably messy. Does byte buddy *ever* get used? if not, can we exclude it from the base import and so no problems downstream. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
