On Thu, 4 Sep 2003, Fredrik Westermarck wrote:
Hopefully I managed to get the diff right. I had to remove several lines by hand because of differences in the indentation (space vs tabs?). Is there any document that describes what codestyle commons-lang is supposed to use?
In general, follow Hen's sage advice below. If you are finding tabs in the source, however, these should be eliminated. If you run maven site:generate, the checkstyle plugin should flag this. It is also always a good idea to run either maven or ant clean dist and review the javadoc report to make sure that all tests run and the patch is not introducing any javadoc warnings or errors.
Thanks for the patches!
Phil
In the long term, a maven site and checkstyle might enforce this, but in real terms the codestyle to use is the same as the nearest neighbour.
So if you're adding a method to NumberUtils, follow the style of NumberUtils. If you're adding a new class to lang.time, follow the style of a core class in lang.time. If you're adding a new package, you should have a good general feel for the style already :)
Basic rules of working on a community codebase I guess.
There are some basic concepts in the DESIGN-GUIDE file which state how XxxUtils classes should be, and there is a checkstyle.xml in there, if you know how to read that.
Hen
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
