Hi Kalle, On Mon, Sep 20, 2010 at 01:00:18PM +0300, Kalle Valo wrote: > Hi Patrik, > > [email protected] writes: > > > From: Patrik Flykt <[email protected]> > > > > request_input_passphrase_reply creates and sends an Agent API RequestInput > > method call and waits for the method call return. The function expects a > > passhphrase_cb_t to be supplied. Only the "Passphrase" dictionary field is > > requested by the method call and only the "Passphrase" dictionary field in > > the method call return is used. > > Just took a quick look, but have one question: > > > + switch (__connman_service_get_security(service)) { > > + case CONNMAN_SERVICE_SECURITY_WEP: > > + value = "wep"; > > + break; > > + case CONNMAN_SERVICE_SECURITY_PSK: > > + value = "psk"; > > + break; > > What about CONNMAN_SERVICE_SECURITY_WPA and > CONNMAN_SERVICE_SECURITY_RSN? > > I haven't understood the difference between the three. CONNMAN_SERVICE_SECURITY_WPA and CONNMAN_SERVICE_SECURITY_RSN are legacy values, when ConnMan used to think it would be good to make a difference between WPA and WPA2. It eventually got merged into CONNMAN_SERVICE_SECURITY_PSK as we realized there is no need for ConnMan to know if we're doing WPA or WPA2.
So Patrik patch is right, and we're keeping the _RSN and _WPA values for legacy reasons. We probably should just get rid of them now. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
