Hi Patrik, On Mon, Sep 20, 2010 at 10:28:07AM +0300, [email protected] wrote: > From: Patrik Flykt <[email protected]> > > Change password query to use RequestInput method call instead of > RequestPassphrase. The supplied passphrase_cb_t function sets the password > returned via Agent API and tries to reconnect to the service. > > A connman_service_set_passphrase helper function has been added by factoring > out the password setting code from set_property. > --- > src/service.c | 48 ++++++++++++++++++++++++++++++++++-------------- > 1 files changed, 34 insertions(+), 14 deletions(-) > > diff --git a/src/service.c b/src/service.c > index b22edb1..ca694f1 100644 > --- a/src/service.c > +++ b/src/service.c > @@ -1377,6 +1377,22 @@ const char > *connman_service_get_proxy_autoconfig(struct connman_service *service > return __connman_ipconfig_get_proxy_autoconfig(service->ipconfig); > } > > +static void connman_service_set_passphrase(struct connman_service *service, > + const char* passphrase) > +{ > + g_free(service->passphrase); > + service->passphrase = g_strdup(passphrase); > + > + passphrase_changed(service); > + > + if (service->network != NULL) > + connman_network_set_string(service->network, > + "WiFi.Passphrase", > + service->passphrase); > + > + __connman_storage_save_service(service); > +} > + > static DBusMessage *get_properties(DBusConnection *conn, > DBusMessage *msg, void *user_data) > { > @@ -1448,16 +1464,7 @@ static DBusMessage *set_property(DBusConnection *conn, > > dbus_message_iter_get_basic(&value, &passphrase); > > - g_free(service->passphrase); > - service->passphrase = g_strdup(passphrase); > - > - passphrase_changed(service); > - > - if (service->network != NULL) > - connman_network_set_string(service->network, > - "WiFi.Passphrase", service->passphrase); > - > - __connman_storage_save_service(service); > + connman_service_set_passphrase(service, passphrase); > } else if (g_str_equal(name, "APN") == TRUE) { > const char *apn; Could you please separate the 2 above hunks into a separate patch that would be the first one of your serie ?
Besides that, the rest of the patchset is fine with me. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
