Hi Matthias, yes, I think this is generally a good way to go.
In JLI_Open(const char* name, int flags), you should remove ret and only use fd, I think. (Currently it would return 0 in the _wopen case). Furthermore, I think it would be a good time to introduce a test now that exercises paths to libjvm of different lengths... Thanks for your work here! Best regards Christoph > -----Original Message----- > From: Alan Bateman <alan.bate...@oracle.com> > Sent: Freitag, 22. März 2019 20:37 > To: Baesken, Matthias <matthias.baes...@sap.com>; Langer, Christoph > <christoph.lan...@sap.com> > Cc: core-libs-dev@openjdk.java.net > Subject: Re: RFR: 8218547: Simplify JLI_Open on Windows in native code > (libjli) - was : RE: RFR : 8217093: Support extended-length paths in > parse_manifest.c on windows > > On 22/03/2019 14:37, Baesken, Matthias wrote: > > Hello, here is the new webrev . > > > > I took over and adjusted coding from os::open + create_unc_path > functions in os_windows.cpp in hotspot : > > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8218547.0/webrev/ > > > This looks quite good. For the comment then it might be better to drop > the mention of os_windows.cpp, also maybe mention that the memory > should > be freed with JLI_MemFree rather than free. > > -Alan
