On 29/03/2019 12:36, Baesken, Matthias wrote:
Thanks.   Alan, are you fine with the current webrev, if yes may I add you as 
reviewer ?

The update to java_md.c looks okay, I probably would re-format the comment to void the line longs but it is otherwise okay.

I think the new test needs a of bit clean-up, L490 is the main issue. One suggest is to rename pLong to longPath and build up ots value in a loop to avoid having a 340+ character line? The other variables names are very strange too but I can you can eliminate some of them by changing L491-492 to:
     Path jarPath = Files.createDirectories(longPah).resolve("foo.jar");

-Alan


Reply via email to