Hello, is the latest revision fine with you ? May I add you as a reviewer ?
Thanks, Matthias > -----Original Message----- > From: Baesken, Matthias > Sent: Dienstag, 2. April 2019 14:55 > To: 'Alan Bateman' <alan.bate...@oracle.com> > Cc: core-libs-dev@openjdk.java.net > Subject: RE: RFR: 8218547: Simplify JLI_Open on Windows in native code > (libjli) - was : RE: RFR : 8217093: Support extended-length paths in > parse_manifest.c on windows > > Hi Alan, here is a new webrev : > > http://cr.openjdk.java.net/~mbaesken/webrevs/8218547.3/webrev/ > > re-formatted the comment in java_md.c to avoid VERY LONG lines > adjusted test/jdk/tools/launcher/Arrrghs.java > > > Best regards, Matthias > > > > > -----Original Message----- > > From: Alan Bateman <alan.bate...@oracle.com> > > Sent: Samstag, 30. März 2019 10:04 > > To: Baesken, Matthias <matthias.baes...@sap.com> > > Cc: core-libs-dev@openjdk.java.net > > Subject: Re: RFR: 8218547: Simplify JLI_Open on Windows in native code > > (libjli) - was : RE: RFR : 8217093: Support extended-length paths in > > parse_manifest.c on windows > > > > On 29/03/2019 12:36, Baesken, Matthias wrote: > > > Thanks. Alan, are you fine with the current webrev, if yes may I add you > as > > reviewer ? > > > > > The update to java_md.c looks okay, I probably would re-format the > > comment to void the line longs but it is otherwise okay. > > > > I think the new test needs a of bit clean-up, L490 is the main issue. > > One suggest is to rename pLong to longPath and build up ots value in a > > loop to avoid having a 340+ character line? The other variables names > > are very strange too but I can you can eliminate some of them by > > changing L491-492 to: > > Path jarPath = Files.createDirectories(longPah).resolve("foo.jar"); > > > > -Alan > >
