On Thu, 12 Jun 2025 18:05:04 GMT, Justin Lu <[email protected]> wrote:
>> Please review this PR which finishes Applet removal for the test:
>> jdk/internal/loader/URLClassPath/ClassnameCharTest.java.
>>
>> `testclasses.jar` is updated such that the two classes no longer extend
>> Applet.
>>
>>
>> $ javap fo\ o.class
>> public class fo o {
>> }
>> $ javap æ$'\302\211'$'\302\213'å$'\302\206'$'\302\214'.class
>> public class 手册 {
>> }
>>
>>
>> The bug description of
>> [JDK-8358729](https://bugs.openjdk.org/browse/JDK-8358729) contains the
>> original `javap` output for those classes.
>>
>> Additionally, the security APIs that were marked for removal are also
>> removed from this test as well.
>
> Justin Lu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Address offline review -> comments for maintainers, simplify exc and
> JAR_PATH
Thank you for the updates Justin.
Looks good overall. If you have to update this test again, it might be
worthwhile considering converting to a junit test
test/jdk/jdk/internal/loader/URLClassPath/ClassnameCharTest.java line 136:
> 134: return defineClass(name, b, 0, b.length, codesource);
> 135: }
> 136: // protocol/host/port mismatch, fail with RuntimeExc
Typo RuntimeExc?
-------------
Marked as reviewed by lancea (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25703#pullrequestreview-2922739662
PR Review Comment: https://git.openjdk.org/jdk/pull/25703#discussion_r2143711460
