On Thu, 12 Jun 2025 21:42:26 GMT, Lance Andersen <lan...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address offline review -> comments for maintainers, simplify exc and >> JAR_PATH > > test/jdk/jdk/internal/loader/URLClassPath/ClassnameCharTest.java line 136: > >> 134: return defineClass(name, b, 0, b.length, >> codesource); >> 135: } >> 136: // protocol/host/port mismatch, fail with RuntimeExc > > Typo RuntimeExc? https://github.com/openjdk/jdk/pull/25703/commits/02c76c749015fc7d59992036625363d16773595f corrects the comment typo and also makes a conversion of this test to JUnit. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25703#discussion_r2145674512