> Can I please get a review of this change which proposes to address the issue 
> noted in https://bugs.openjdk.org/browse/JDK-8372787?
> 
> The commit in this PR takes into account the `IllegalStateException` thrown 
> by `JarFile` APIs and wraps them into a `IOException` to conform with the 
> expectations of the `ModuleReader` APIs.
> 
> A new jtreg test has been introduced to reproduce the issue and verify the 
> fix. CI testing is currently in progress with this change.

Jaikiran Pai has updated the pull request incrementally with two additional 
commits since the last revision:

 - 8372787: ModuleReader should throw IOException consistently when using 
--patch-module and ModuleReader is closed
 - Revert "8372787: ModulePatcher throws unspecified IllegalStateException upon 
being invoked after close()"
   
   This reverts commit 42cfa0aa40926b748c6d7bdf814d85ca1ccd8fed.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28569/files
  - new: https://git.openjdk.org/jdk/pull/28569/files/42cfa0aa..d0d261d1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28569&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28569&range=00-01

  Stats: 239 lines in 4 files changed: 108 ins; 126 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/28569.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28569/head:pull/28569

PR: https://git.openjdk.org/jdk/pull/28569

Reply via email to