On Mon, 1 Dec 2025 10:41:15 GMT, Alan Bateman <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8372787: ModuleReader should throw IOException consistently when using >> --patch-module and ModuleReader is closed >> - Revert "8372787: ModulePatcher throws unspecified IllegalStateException >> upon being invoked after close()" >> >> This reverts commit 42cfa0aa40926b748c6d7bdf814d85ca1ccd8fed. > > test/jdk/java/lang/module/ModuleReader/patched/PatchedModuleReaderTest.java > line 84: > >> 82: "ModuleReader.open(String)"); >> 83: assertThrows(IOException.class, () -> reader.find(rn), >> 84: "ModuleReader.find(String)"); > > Would it be possible to say which methods throw ISE or IOE? (I mean in a PR > comment, not in the test). Do you mean which of these 3 methods (find, read and open()) were failing without this fix? `find()` and `open()` were failing to throw an IOException before this fix, thus failing this test. Do note that the current updated test doesn't actually exercise the `JarResourceFinder`. So this failing test wasn't seeing a `IllegalStateException` from any of these methods. I can update this test to additionally include a JAR file as a path to --patch-module, if you suggest. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28569#discussion_r2576605360
