On Mon, 1 Dec 2025 10:22:19 GMT, Jaikiran Pai <[email protected]> wrote:
>> Can I please get a review of this change which proposes to address the issue >> noted in https://bugs.openjdk.org/browse/JDK-8372787? >> >> The commit in this PR takes into account the `IllegalStateException` thrown >> by `JarFile` APIs and wraps them into a `IOException` to conform with the >> expectations of the `ModuleReader` APIs. >> >> A new jtreg test has been introduced to reproduce the issue and verify the >> fix. CI testing is currently in progress with this change. > > Jaikiran Pai has updated the pull request incrementally with two additional > commits since the last revision: > > - 8372787: ModuleReader should throw IOException consistently when using > --patch-module and ModuleReader is closed > - Revert "8372787: ModulePatcher throws unspecified IllegalStateException > upon being invoked after close()" > > This reverts commit 42cfa0aa40926b748c6d7bdf814d85ca1ccd8fed. Based on the discussion in the linked JBS issue, I have changed the proposed fix and also rewritten the new jtreg test case. The test fails without the source changes in this PR and passes with it. When it fails, it fails due to the IOException not being thrown after the ModuleReader has been closed. I think this addresses the underlying problem that you described in the issue. If not, please do let me know and I will discuss with you further. ------------- PR Comment: https://git.openjdk.org/jdk/pull/28569#issuecomment-3595768885
