On Mon, 1 Dec 2025 10:38:48 GMT, Alan Bateman <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8372787: ModuleReader should throw IOException consistently when using
>> --patch-module and ModuleReader is closed
>> - Revert "8372787: ModulePatcher throws unspecified IllegalStateException
>> upon being invoked after close()"
>>
>> This reverts commit 42cfa0aa40926b748c6d7bdf814d85ca1ccd8fed.
>
> src/java.base/share/classes/jdk/internal/module/ModulePatcher.java line 420:
>
>> 418: }
>> 419:
>> 420: private void ensureOpen() throws IOException {
>
> Can you move this to after the delegate() method?
Done, I've updated the PR to move this just after the delegate() method.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28569#discussion_r2576587433
