On Mon, 13 Jul 2026 23:01:32 GMT, Naoto Sato <[email protected]> wrote:
>> Sholto has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8272194: expand dates covered by faster code path in >> LocalDate/LocalDateTime conversion > > test/jdk/java/sql/test/sql/TimestampTests.java line 727: > >> 725: LocalDateTime.of(-4, 9, 8, 23, 11, 59, 999_999_999), >> 726: LocalDateTime.of(-1000, 3, 22, 8, 30, 20, 0) >> 727: ); > > Could you make this a JUnit parameterized test, using `@ParameterizedTest`, > rather than iterating over a List? Please also add dates/date-times > immediately around the cutoff to verify the conversion there, particularly > that values at or after the cutoff are AD, even with the possible negative > offset? I have made the tests `@ParameterizedTest` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31808#discussion_r3577519500
