On Tue, 14 Jul 2026 09:09:51 GMT, Sholto <[email protected]> wrote: >> test/jdk/java/sql/test/sql/TimestampTests.java line 727: >> >>> 725: LocalDateTime.of(-4, 9, 8, 23, 11, 59, 999_999_999), >>> 726: LocalDateTime.of(-1000, 3, 22, 8, 30, 20, 0) >>> 727: ); >> >> Could you make this a JUnit parameterized test, using `@ParameterizedTest`, >> rather than iterating over a List? Please also add dates/date-times >> immediately around the cutoff to verify the conversion there, particularly >> that values at or after the cutoff are AD, even with the possible negative >> offset? > > I have made the tests `@ParameterizedTest`
I have also added tests to check the dates around our BC check threshold. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31808#discussion_r3577811676
