On Mon, 3 Aug 2026 02:42:13 GMT, by1361092 <[email protected]> wrote: > Please review this change. Thanks! > > The launcher test Settings.java compares command output against expected > text. The test was sensitive to the default locale because the expected > output was assumed to be in English. > > This change makes the test run with the en-US locale explicitly to ensure > stable test results regardless of the default locale. > > Testing: > - jtreg test/jdk/tools/launcher/Settings.java with LANG=zh_CN.utf8 and > LC_ALL=zh_CN.utf8: passed. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai).
test/jdk/tools/launcher/Settings.java line 29: > 27: /* > 28: * @test > 29: * @bug 6994753 7123582 8305950 8281658 8310201 8311653 8343804 8351354 > 8366364 8387750 8388366 @by1361092, the OpenJDK development guide has a section about jtreg tests https://openjdk.org/guide/#jtreg. One part of that explains when to add/update a `@bug` tag in the test defintion. Specifically: > These bug ids refer to product bugs for which a fix is verified by this test. > JBS issues that track changes to the test itself are not listed here. Given that the current change is a change to the test itself, the addition of 8388366 isn't needed here. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32167#discussion_r3705427108
