On Mon, 3 Aug 2026 15:51:00 GMT, Jaikiran Pai <[email protected]> wrote:

> The test changes here are more extensive than what I had thought this would 
> be. The proposed change here passes around `LANG` and `LC_ALL` environment 
> variables, set to `en_US.UTF-8` when launching `java`. As far as I know, the 
> usage of these environment variables isn't specified by the Java runtime.

Right. `LANG` and `LC_ALL` are platform-dependent. In fact, they are not 
honored on Windows, so I am not sure the proposed fix would work there 
(although I haven't confirmed this).

> My impression of this JBS issue was that the change would be merely to update 
> the `@run` action to launch it in `othervm` and setting the `user.language` 
> and `user.country` to `en` and `US` respectively 
> https://docs.oracle.com/en/java/javase/26/docs/api/java.base/java/util/Locale.html#default_locale.

I agree that the test should use the `user.language=en` and `user.country=US` 
system properties. However, they need to be passed to the actual java launcher 
invocation options.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/32167#issuecomment-5170519071

Reply via email to