On Mon, 3 Aug 2026 15:51:00 GMT, Jaikiran Pai <[email protected]> wrote:
>> Please review this change. Thanks! >> >> The launcher test Settings.java compares command output against expected >> text. The test was sensitive to the default locale because the expected >> output was assumed to be in English. >> >> This change makes the test run with the en-US locale explicitly to ensure >> stable test results regardless of the default locale. >> >> Testing: >> - jtreg test/jdk/tools/launcher/Settings.java with LANG=zh_CN.utf8 and >> LC_ALL=zh_CN.utf8: passed. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > The test changes here are more extensive than what I had thought this would > be. The proposed change here passes around `LANG` and `LC_ALL` environment > variables, set to `en_US.UTF-8` when launching `java`. As far as I know, the > usage of these environment variables isn't specified by the Java runtime. > > My impression of this JBS issue was that the change would be merely to update > the `@run` action to launch it in `othervm` and setting the `user.language` > and `user.country` to `en` and `US` respectively > https://docs.oracle.com/en/java/javase/26/docs/api/java.base/java/util/Locale.html#default_locale. > > Naoto would know more, so please wait for his inputs. @jaikiran @naotoj Thanks for the reviews and helpful suggestions. I appreciate your help. Could you please sponsor the change? Thanks! ------------- PR Comment: https://git.openjdk.org/jdk/pull/32167#issuecomment-5211174896
