"Huo, Halton" <[email protected]> writes: > 1. I created 23 more commits to fix crosswalk repo issues, each commit > either fix a compiler issue or a crash issue. You could get the latest > list from https://github.com/halton/crosswalk/commits/master . My > question is should I merge all above commits into one? Personally, I > prefer one commits fix one issue, it is more clear that why the code > change like that.
While keeping separate commits is normally the preferred approach, for rebasing you should squash everything together, otherwise the build will be broken for 22 commits (unless some of your fixes also apply to the current crosswalk/chromium-crosswalk version, in which case they should be sent separately and landed independently before the rest for your work). _______________________________________________ Crosswalk-dev mailing list [email protected] https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
