Hi, > I do have questions on how to review the rebasing patches: > 1. What the review process for the rebasing patches? I do not think PR to > crosswalk-project repos is good because it need freeze them.I prefer to give > my repos link, is that okay to you?
When you are sure you are ready to move on with the rebase, then it is time to open the PR for the build-fixes in Crosswalk. When that moment is reached, it is also fine to communicate us all that the tree is closed. (1 email here and 1 message on #crosswalk is fine). Reviewing such big diffs on your repos is a no go, sorry. Let's stick to the close_tree-open_PR-ask_for_review workflow please. > 2. Who should the reviewer? Alexis, Kenneth, Caio, Raphael, who else? I will also help reviewing since I'm the one who did the last rebase. I would like also to follow what is going with chromium-crosswalk and blink-crosswalk. > 3. And which way do you want to review? Multiple commits or all-in-one commit? Again, we have decided this already and it is well documented at https://github.com/crosswalk-project/crosswalk-website/wiki/Rebasing-our-forks The build fixes for Crosswalk should all be squashed into a single commit. For chromium-crosswalk and blink-crosswalk we keep one commit per fix/cherry-pick/revert, etc. Please make sure you follow that document. It is _very_ helpful and works like a checklist! Cheers, jesus _______________________________________________ Crosswalk-dev mailing list [email protected] https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
