Hi, On Nov 12, 2013, at 8:14 AM, Huo, Halton <[email protected]> wrote:
> Hi All, > > I maintain a 32 rebasing cycle dashboard on > https://docs.google.com/a/intel.com/spreadsheet/ccc?key=0AsFIcUvdloeddEJ1NTRPUThUaWRfUjlXR1hzbkk2NVE&usp=sharing#gid=0 > > The current code is based on 32.0.1700.4(I will update the latest dev version > when is ready to push). So far, there are some issues is fixing: > 1. Xwalk on windows crash(Shiliu/Ningxin is taking care) > 2. Xwalk instrumentation test crash (Yongsheng is taking care) > 3. Xwalk testing on Tizen device(Halton is taking care) > > Opens: > 1. I created 23 more commits to fix crosswalk repo issues, each commit > either fix a compiler issue or a crash issue. You could get the latest list > fromhttps://github.com/halton/crosswalk/commits/master . My question is > should I merge all above commits into one? Personally, I prefer one commits > fix one issue, it is more clear that why the code change like that. NOTE, I > add the reversion that cause the xwalk code change. For example: > commit 27000c53350ce4bc6c32d859c08211a5f323566f > Author: Halton Huo [email protected] > Date: Tue Nov 12 11:25:42 2013 +0800 > > [Tizen] Add ET_GESTURE_SHOW_PRESS case to fix gcc error. > > Introduced by src@230206 I thing it would be better to squash so that we can revert easily if needed (and specially useful for bisect). Btw but I’m sure you are aware, these commits need to go through review before landing. > 2. What the rule of xwalk build version should be? Currently I use > 3.32.4.0 (4 from 1700.4). > > Any suggestions or comments? No this is incorrect. The third digit is the build number which is unrelated to the other bits. You should not modify it, the canary builder will do that for you. Just let it the way it is in master. > > BTW, I won’t call for repo freeze until I’m ready for push the rebasing code. > > Thanks, > Halton. _______________________________________________ Crosswalk-dev mailing list [email protected] https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
