On Nov 13, 2013, at 11:34 PM, Huo, Halton <[email protected]<mailto:[email protected]>> wrote:
Again, we have decided this already and it is well documented at https://github.com/crosswalk-project/crosswalk-website/wiki/Rebasing-ou r-forks The build fixes for Crosswalk should all be squashed into a single commit. For chromium-crosswalk and blink-crosswalk we keep one commit per fix/cherry-pick/revert, etc. Please make sure you follow that document. It is _very_ helpful and works like a checklist! Alesix/Jesus, Thanks for clarification. I'll follow that. Actually, I do follow that document you menthioned, Alexis point me last week. But it does not mention about the review thing. And I do not notice this step for previous rebasing cycles, maybe I miss something. For crosswalk the review of the build fixes happened there : https://github.com/crosswalk-project/crosswalk/pull/819 For the rebased patches as there is no « PR » then no way to comment so we did that over IRC. That part is a bit of trust TBH. As for the checklist, I do have a dashboard on https://docs.google.com/a/intel.com/spreadsheet/ccc?key=0AsFIcUvdloeddEJ1NTRPUThUaWRfUjlXR1hzbkk2NVE&usp=sharing#gid=0. I use that to communicate with commit owner and status tracking. Thanks, Halton. _______________________________________________ Crosswalk-dev mailing list [email protected] https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
