> > I thing it would be better to squash so that we can revert easily if needed > (and specially useful for bisect). Btw but I'm sure you are aware, these > commits need to go through review before landing. [halton] Aleis and Raphael, thanks for the commits. Your reason does make sense to me, I'll squash them all when pushing.
I do have questions on how to review the rebasing patches: 1. What the review process for the rebasing patches? I do not think PR to crosswalk-project repos is good because it need freeze them.I prefer to give my repos link, is that okay to you? 2. Who should the reviewer? Alexis, Kenneth, Caio, Raphael, who else? 3. And which way do you want to review? Multiple commits or all-in-one commit? > No this is incorrect. The third digit is the build number which is unrelated > to the other bits. You should not modify it, the canary builder will do that > for you. Just let it the way it is in master. [halton] Thanks for the info, I'll keep the build number untouched. _______________________________________________ Crosswalk-dev mailing list [email protected] https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
