Dan Anderson wrote:
> Here's a review for:
> 6414175 kcf.conf's supportedlist not providing much usefulness
>
> http://dan.drydog.com/reviews/6414175-kcfconf/
>
Changes look good to me. I've some comments.
usr/src/cmd/cmd-crypto/cryptoadm/cryptoadm.h:
lines 98-103, 109, 116-117, 140-141, 153, 165-166
Nit - No need to give the variable name for each parameter
declared in the extern function prototype. Thought to be
consistent with others in this file.
usr/src/uts/common/crypto/core/kcf_cryptoadm.c:
line 45
Suggest to initialize the last entry in the table as a "" or NULL,
so that when walking through the entire table, we know where it
should stop at. We don't need to define the constant of each
array size, and modify it whenever the size grows or shrinks.
static initial_soft_config_entry_t
initial_soft_config_entry[] = {
"des", DES_MECH_COUNT, des_mechs,
...
"swrand", SWRAND_MECH_COUNT, swrand_mechs,
"",0,NULL
usr/src/pkgdefs/SUNWdcar/preremove:
usr/src/pkgdefs/SUNWn2cp.v/preremove:
lines 31-32
Comments need update.
Hai-May
