Hai-may,
I incorporated your comments and updated the webrev.
The updated version is at:
http://dan.drydog.com/reviews/6414175-kcfconf-1/
- Dan
> Changes look good to me. I've some comments.
>
> usr/src/cmd/cmd-crypto/cryptoadm/cryptoadm.h:
>
> lines 98-103, 109, 116-117, 140-141, 153, 165-166
> Nit - No need to give the variable name for each parameter
> declared in the extern function prototype. Thought to be
> consistent with others in this file.
I prefer having the variable names in the function prototypes--it makes it
easier to read. I think all function prototypes should have the names, but I
just didn't do it this time.
> usr/src/uts/common/crypto/core/kcf_cryptoadm.c:
>
> line 45
>
> Suggest to initialize the last entry in the table as a "" or NULL,
> so that when walking through the entire table, we know where it
> should stop at. We don't need to define the constant of each
> array size, and modify it whenever the size grows or shrinks.
>
> static initial_soft_config_entry_t
> initial_soft_config_entry[] = {
> "des", DES_MECH_COUNT, des_mechs,
> ...
> "swrand", SWRAND_MECH_COUNT, swrand_mechs,
> "",0,NULL
FIXED. I used sizeof and added a count_mechanisms() static function
to remove the need of the hard-coded INITIAL_SOFT_CONFIG_ENTRIES
>
>
> usr/src/pkgdefs/SUNWdcar/preremove:
> usr/src/pkgdefs/SUNWn2cp.v/preremove:
>
> lines 31-32
>
> Comments need update.
FIXED.
--
This message posted from opensolaris.org
